chore: stdlib bool internal audit #15070
Merged
iakovenkos merged 20 commits intoJul 4, 2025
Merged
Conversation
iakovenkos
commented
Jun 30, 2025
iakovenkos
commented
Jun 30, 2025
iakovenkos
commented
Jun 30, 2025
iakovenkos
commented
Jun 30, 2025
iakovenkos
commented
Jun 30, 2025
iakovenkos
commented
Jun 30, 2025
| ASSERT(result == true); | ||
| } | ||
|
|
||
| bool_t acc = witness_t(ctx, true); // will accumulate the conjunctions of each condition (i.e. `&&` of each) |
Contributor
Author
There was a problem hiding this comment.
unconstrained witness, replaced with a constant true, it'll be turned into a witness after && with the first witness
iakovenkos
changed the title
suyash67
reviewed
Jul 2, 2025
suyash67
reviewed
Jul 2, 2025
suyash67
reviewed
Jul 2, 2025
suyash67
reviewed
Jul 2, 2025
suyash67
reviewed
Jul 2, 2025
| /** | ||
| * @brief Implements implication operator in circuit. | ||
| */ | ||
| template <typename Builder> bool_t<Builder> bool_t<Builder>::implies(const bool_t<Builder>& other) const |
Contributor
There was a problem hiding this comment.
implies, must_imply and implies_both_ways were added for aztec connect if I remember correctly. If these are not being used anywhere (including noir), I am in favour of removing them. Ideally, I think bool class should only contain standard operations (!, |, ^, &).
Contributor
There was a problem hiding this comment.
I think only must_imply is currently being used in ecdsa verifier and some places in recursive verifier.
suyash67
approved these changes
Jul 3, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). chore: stdlib bool internal audit (#15070) feat: improve Shplonk api (#15422) fix(merge-train): don't queue merge if merge-train failed queue, pass on rebase logic (#15508) chore: nuke bit array (#15522) chore: remove template parameters (#15530) --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). BEGIN_COMMIT_OVERRIDE chore: stdlib bool internal audit (#15070) feat: improve Shplonk api (#15422) fix(merge-train): don't queue merge if merge-train failed queue, pass on rebase logic (#15508) chore: nuke bit array (#15522) chore: remove template parameters (#15530) chore: no PK (#15386) chore!: Correct public inputs propagation in the tube (#15547) chore: use `batch_invert` in native IPA verifier (#15557) chore: Move `stdlib::uint_plookup` to `stdlib::uint` (#15460) chore: use const ref commitment keys (#15584) fix: hiding circuit vk computed only once (#15589) feat: transcript can hash objects independently (#15510) chore: readme for benchmarking remotely (#15512) chore: fix avm test (#15592) chore: hash more stuff for IPA. (#15519) chore: fix avm build in merge-train/bb (#15594) feat!: structured public inputs via kernel io (#15383) fix!: aggregate correct nested pairing points in the hiding circuit (#15598) fix: bb merge-train conflicts (#15617) chore: Refactor shplonk verifier api (#15618) chore!: databus consistency checks in the hiding circuit (#15599) feat!: VK hash consistency check (#15591) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com> Co-authored-by: Raju Krishnamoorthy <krishnamoorthy@gmail.com> Co-authored-by: notnotraju <raju@aztec-labs.com> Co-authored-by: Lucas Xia <lucasxia01@gmail.com> Co-authored-by: Khashayar Barooti <khashayar@aztecprotocol.com> Co-authored-by: Jean M <132435771+jeanmon@users.noreply.github.com> Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Santiago Palladino <spalladino@users.noreply.github.com> Co-authored-by: Santiago Palladino <santiago@aztec-labs.com>
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
See [merge-train-readme.md](https://github.com/AztecProtocol/aztec-packages/blob/next/.github/workflows/merge-train-readme.md). chore: stdlib bool internal audit (AztecProtocol#15070) feat: improve Shplonk api (AztecProtocol#15422) fix(merge-train): don't queue merge if merge-train failed queue, pass on rebase logic (AztecProtocol#15508) chore: nuke bit array (AztecProtocol#15522) chore: remove template parameters (AztecProtocol#15530) --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: sergei iakovenko <105737703+iakovenkos@users.noreply.github.com> Co-authored-by: federicobarbacovi <171914500+federicobarbacovi@users.noreply.github.com> Co-authored-by: Suyash Bagad <suyash@aztecprotocol.com> Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com> Co-authored-by: ledwards2225 <98505400+ledwards2225@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our basic binary ops produce a new gate iff both operands are witnesses. Most of the implementations contained deeply branched logic that is now replaced with simple
intarithmetic that looks more robust and is much easier to read.Added documentation in various places. The constraints are made more explicit
Removed redundant assignments
Re-worked the test suite. Now all basic ops and functions are tested for all combinations of flags (
is_constant,witness_bool,witness_inverted). Added missing tests, checked various edge cases.Removed a couple of tests that seemed less expressive
Removed
must_imply()method for a vector of implications, as it is not used anymoreFixed a
normalize()regression - previously it wouldn't check if (witness_inverted == false) and would normalize a witnessbool_teven if the condition is satisfied. It is the reason for the VK changes